Canonical CI: grouped-tests.yml + root test/test_groups.toml#305
Merged
ChrisRackauckas merged 4 commits intoJun 10, 2026
Merged
Conversation
Convert the root CI test workflow to the canonical thin caller of SciML/.github grouped-tests.yml@v1, with the version/group matrix declared once in test/test_groups.toml. - CI.yml: replace the hand-maintained group x version matrix job with the thin grouped-tests.yml@v1 caller (on:/concurrency: preserved verbatim). - test/test_groups.toml: [Core] on lts/1/pre, [QA] on lts/1. - runtests.jl: add GROUP dispatch; existing suite runs under Core/All, QA activates test/qa and runs Aqua/JET. - test/qa: isolated QA environment (Aqua + JET + Test + package via path source) running Aqua.test_all and JET.test_package. - Project.toml: bump julia compat floor to 1.10 (LTS) and add [compat] entries for every [extras] dependency (benign Aqua metadata fixes). QA group newly wired; Aqua/JET run in CI -- any failures will be triaged in follow-up. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Core test group runs with project='.' and test/runtests.jl does `using Pkg` (for the QA group's Pkg.activate), but Pkg was not a declared test dependency, causing the Core job to fail with `ArgumentError: Package Pkg not found in current path`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The grouped-tests conversion placed using statements inside a top-level GROUP if-block that also uses macros (@testset/@safetestset) inline. Julia macro-expands the whole if-block before the in-block using runs, so the macro is undefined at expansion time. Move the functional usings to top level (above const GROUP) so the macros resolve. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Keeps all passing Aqua sub-checks running and the JET check intact; disables only the failing Aqua sub-checks and asserts them via @test_broken so they remain visible and auto-flag once fixed. Findings tracked in SciML#306. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root CI test workflow to the canonical SciML thin caller of
grouped-tests.yml@v1, declaring the version/group matrix once in a roottest/test_groups.tomlinstead of hand-maintaining it in YAML..github/workflows/CI.yml: the hand-maintainedgroup × versionmatrix job is replaced by the thin caller:with:overrides are needed — the old job usedtests.yml's defaults forcheck-bounds(yes) andcoverage(true), which matchgrouped-tests.yml's defaults. Theon:andconcurrency:blocks are preserved verbatim. Linux-only (noosfield).test/test_groups.toml(new root matrix):test/runtests.jl: addsGROUPdispatch. The existing suite runs underCore/All;QAactivates the isolatedtest/qaenvironment and runs Aqua/JET.test/qa/(new): isolated QA env —Aqua+JET+Test+ the package via a path[sources]entry — runningAqua.test_all(DiffEqParamEstim)andJET.test_package(DiffEqParamEstim; target_defined_modules=true).Project.toml: benign metadata fixes — bumpjuliacompat floor1.6→1.10(LTS), and add[compat]entries for every[extras]dependency that lacked one.Matrix match
Old matrix (
CI.yml):group = Allon versions1,lts,pre(3 cells,ubuntu-latest).New matrix, emitted by
compute_affected_sublibraries.jl . --root-matrix(verified statically):Core× {lts,1,pre} — reproduces the old 3-cell test matrix exactly (group renamedAll→Coreper the canonical convention;runtests.jldispatches both to the same suite).QA× {lts,1} — newly wired Aqua/JET (2 new cells).QA group newly wired; Aqua/JET run in CI — any failures will be triaged in a follow-up.
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code